Skip to content

Conversation

@BenWibking
Copy link
Collaborator

Replaces const std::string usage with constexpr std::string_view.

@BenWibking BenWibking requested a review from zingale June 26, 2025 15:11
@BenWibking BenWibking changed the title use constexpr std::string_view Use constexpr std::string_view Jun 26, 2025
@BenWibking
Copy link
Collaborator Author

The Castro CI failure looks unrelated:

../../../Source/gravity/Gravity.cpp: In member function ‘amrex::Real Gravity::actual_solve_with_mlmg(int, int, const amrex::Vector<amrex::MultiFab*>&, const amrex::Vector<const amrex::MultiFab*>&, const amrex::Vector<std::array<amrex::MultiFab*, 2>, std::allocator<std::array<amrex::MultiFab*, 2> > >&, const amrex::Vector<amrex::MultiFab*>&, const amrex::MultiFab*, amrex::Real, amrex::Real) const’:
../../../Source/gravity/Gravity.cpp:3777:18: error: ‘using amrex::MLMG = class amrex::MLMGT<amrex::MultiFab>’ {aka ‘class amrex::MLMGT<amrex::MultiFab>’} has no member named ‘setConvergenceNormType’
 3777 |             mlmg.setConvergenceNormType(MLMGNormType::bnorm);
      |                  ^~~~~~~~~~~~~~~~~~~~~~
../../../Source/gravity/Gravity.cpp:3777:41: error: ‘MLMGNormType’ has not been declared
 3777 |             mlmg.setConvergenceNormType(MLMGNormType::bnorm);
      |                                         ^~~~~~~~~~~~
make: *** [/home/runner/work/Microphysics/Microphysics/amrex/Tools/GNUMake/Make.rules:260: tmp_build_dir/o/2d.gnu.EXE/Gravity.o] Error 1

@zingale
Copy link
Member

zingale commented Jun 26, 2025

yes, that is unrelated. It will go away once we merge development in Castro.

@zingale zingale merged commit 86ca144 into AMReX-Astro:development Jun 26, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants