update get_actual_nse_state with a general interface with different inputs: (rho, T, Ye) and (rho, e, Ye) #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
okay I think this is good for review. I added the new constraint and jacobian for (rho, e, Ye) input in my local branch. And it seems to work. I need to do some optimization and I'll open another pr for that. |
zingale
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update get_actual_nse_state with a general interface with different inputs: (rho, T, Ye) and (rho, e, Ye).
Separate out constraint eq and jacobian to a separate header for better organization.
Moved stuff in nse_eos.H to nse_solver.H to avoid circular dependency.
I will add new fcn and jcn with (rho, e, Ye) input in a future pr.