fix subtle bug in he-burn derived rates #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This was uncovered by this PR: pynucastro/pynucastro#1112 |
zhichen3
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the he_burn_core.py script, we create a merged library all_lib from core_lib, but
then proceed to still use core_lib for the detailed balance. This still works in the end
because the _rates dict is shared between the two. But we should really be operating
on all_lib. This becomes an issue if we fix this behavior in pynucastro, such that
library addition results in a new library with its own _rates.
The rate ordering here is slightly different now, since the remove rates from the derivation
are now called _derived_removed.