add support for self-consistent NSE to test_sdc #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will let us add tests to the regression test suite
Member
Author
|
this works, but no cells enter NSE, so I think I need to tweak the inputs a bit |
zingale
changed the title
Member
Author
|
okay it works now with |
zhichen3
approved these changes
Dec 9, 2025
| @@ -0,0 +1,24 @@ | |||
| n_cell = 16 | |||
|
|
|||
| prefix = react_aprox19_sdc_ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will let us add tests to the regression test suite.
Also, when NSE is enabled, this will output the fraction of zones that entered NSE at the end.