Skip to content

Remove dependency on App Engine SDK in EndpointsAuthenticator#39

Merged
clementdenis merged 1 commit intomasterfrom
gae_sdk_runtime_dependency
Aug 21, 2019
Merged

Remove dependency on App Engine SDK in EndpointsAuthenticator#39
clementdenis merged 1 commit intomasterfrom
gae_sdk_runtime_dependency

Conversation

@clementdenis
Copy link

No description provided.

@RaHery
Copy link

RaHery commented Aug 21, 2019

@clementdenis Could you check please, some tests did not pass.
Thanks

@clementdenis clementdenis force-pushed the gae_sdk_runtime_dependency branch from dca92b2 to 734ba65 Compare August 21, 2019 08:50
@clementdenis
Copy link
Author

Rebased on master, should fix it.

@clementdenis
Copy link
Author

Actually, master won't pass tests until #37 is merged.
Can you review this it? I'll rebase on updated master once merged.

@clementdenis clementdenis force-pushed the gae_sdk_runtime_dependency branch from 734ba65 to 9575c88 Compare August 21, 2019 13:31
@codecov-io
Copy link

Codecov Report

Merging #39 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage      81.8%   81.76%   -0.05%     
+ Complexity     1821     1820       -1     
============================================
  Files           159      159              
  Lines          6634     6634              
  Branches        871      872       +1     
============================================
- Hits           5427     5424       -3     
- Misses          883      885       +2     
- Partials        324      325       +1
Impacted Files Coverage Δ Complexity Δ
...le/api/server/spi/auth/EndpointsAuthenticator.java 94.11% <0%> (-5.89%) 6 <0> (ø)
.../server/spi/auth/GoogleAppEngineAuthenticator.java 82.14% <0%> (-3.58%) 15% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d325ec...9575c88. Read the comment docs.

@clementdenis clementdenis merged commit 4d05877 into master Aug 21, 2019
@clementdenis clementdenis deleted the gae_sdk_runtime_dependency branch August 21, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants