Refactor param reader to handle properly name conflicts between param…#44
Merged
clementdenis merged 1 commit intomasterfrom Oct 22, 2019
Merged
Refactor param reader to handle properly name conflicts between param…#44clementdenis merged 1 commit intomasterfrom
clementdenis merged 1 commit intomasterfrom
Conversation
…s and body - Do not "merge" body with query and path params - Improve errors on JSON parsing errors
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
============================================
+ Coverage 82.28% 82.29% +<.01%
- Complexity 1856 1857 +1
============================================
Files 158 158
Lines 6718 6731 +13
Branches 889 890 +1
============================================
+ Hits 5528 5539 +11
Misses 868 868
- Partials 322 324 +2
Continue to review full report at Codecov.
|
alarribeau
approved these changes
Oct 22, 2019
alarribeau
left a comment
alarribeau
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @llbrt)
llbrt
approved these changes
Oct 22, 2019
llbrt
left a comment
llbrt
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s and body