Fix memcpy/sizeof typo in avifImageCopy#483
Merged
wantehchang merged 1 commit intoAOMediaCodec:masterfrom Jan 30, 2021
Merged
Conversation
wantehchang
approved these changes
Jan 30, 2021
Collaborator
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
LGTM. Nice catch. Thanks a lot for the fix!
Joe: We should switch to struct assignment to avoid this class of bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across this typo while trying to debug i686 CI failures for python-pillow/Pillow#5201.
sizeof(dstImage->pasp)is 8, butsizeof(dstImage->imir)is 1. On 32-bit architectures that meant that theavifImage->exifpointer was fully copied todstImage. This resulted in a double free abort, because bothavifEncoderDataDestroyandavifImageDestroywere doing afreeof the same location in memory (ofencoder->data->metadataImage->exifandimage->exif, respectively).