Skip to content

Feature/upgrade standard token contract#1

Merged
surabhil merged 5 commits intodevfrom
feature/upgrade-standard-token-contract
Dec 10, 2018
Merged

Feature/upgrade standard token contract#1
surabhil merged 5 commits intodevfrom
feature/upgrade-standard-token-contract

Conversation

@surabhil
Copy link

@surabhil surabhil commented Dec 5, 2018

  • Use EOSIO_DISPATCH instead of EOS_ABI
  • Update contract to use symbol_code instead of symbol_name
  • Use eosio replacement of account_name to name
  • Explicitely use name.value to query in table as it converts name type to uint64_t
  • Update multi indexes to the new format as per eosio
  • Add class type (eosio::contract("ore.standard_token")) in the class definition
  • Anotate all tables and actions with eosio::action/table for abi generation
  • Add open and close actions as added in eosio.token contract in EOSIO/eoiso.contracts latest version
  • Use TABLE and ACTION macros

Copy link

@blackwatertepes blackwatertepes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, I'd wait for another Review, before merging.

@surabhil surabhil requested a review from bas4r December 8, 2018 02:56
@bas4r
Copy link

bas4r commented Dec 10, 2018

Looks good to me as well

@surabhil surabhil merged commit b9e9b5b into dev Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants