Skip to content

Feature/upgrade instrument, right_registry and usage_log contract#3

Merged
surabhil merged 15 commits intofeature/upgrade-standard-token-contractfrom
feature/upgrade-instrument-contract
Dec 10, 2018
Merged

Feature/upgrade instrument, right_registry and usage_log contract#3
surabhil merged 15 commits intofeature/upgrade-standard-token-contractfrom
feature/upgrade-instrument-contract

Conversation

@surabhil
Copy link

@surabhil surabhil commented Dec 7, 2018

  • Upgrades to ore.instrument, ore.rights_registry and ore.usage_log

    • Use Action and Table macros
    • initialize classes with initalising the new base constructor of eosio::contract
    • Initialize indexes in the constructor
    • typedef mutlindexes
    • replace account_name with name
    • use symbol_code and its related methods instead of symbol_name
    • use "_n to get the name instead of N{
    • use account_name.value to get uint64_t representation of account name
    • use new permission level object
    • replace deprecated types.hpp with transaction.hpp
    • replace deprecated time type with time_point_in_sec
    • add comments and update eosio_assert messages
  • Upgrades specific to ore.instrument contract

    • changed minted_at to take current time instead of hard coded 0 value
  • remove unused code related to allowance of instrument

  • change token_id to instrument_id to maintain consistency throughout the contract

  • Upgrades specific to ore.rights_registry contract

    • initialize multi index (_rights) on a higher level instead of duplicating it across functions
  • Upgrades specific to ore.usage_log contract

    • initialize the logs multiindex with the constructor

@surabhil surabhil requested review from bas4r and traylewin and removed request for traylewin December 8, 2018 02:33
@surabhil surabhil changed the title Feature/upgrade instrument contract Feature/upgrade instrument, right_registry and usage_log contract Dec 10, 2018
@bas4r
Copy link

bas4r commented Dec 10, 2018

Looks good

@surabhil surabhil merged commit 9f21b94 into feature/upgrade-standard-token-contract Dec 10, 2018
@surabhil surabhil deleted the feature/upgrade-instrument-contract branch December 10, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants