Build with new master of urdfdom (after they switched to tinyxml2) #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest urdfdom release (3.0.0) doesn't include this change as of today. For further reading: https://discourse.ros.org/t/upcoming-api-break-in-urdfdom/34750
Include tinyxml2 header.
Contributor
|
I am afraid this works only for Rock as it pulls urdfdom from master branch. It works neither for ROS2 nor when using the normal install (both use urdfdom-dev V3.01, which uses tinyxml). I think Rock should use better a fixed version of urdfdom. |
Contributor
|
According to ros/urdfdom@29426ec a the newest urdfdom release (4.0.0) uses tinyxml2 apparently this will be the version to be used in ROS2: https://discourse.ros.org/t/upcoming-api-break-in-urdfdom/34750. I also think that rock could pin to a urdfdom release. But I think this will be 4.0.0 then.. |
Contributor
|
Should be fixed on master, maybe you can give it a try? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWIW: These are the required changes to build after urdfdom master switched to depend on tinyxml2 (instead of old tinyxml).
The rock package set provides the master version with the updated dependency (since this update: rock-core/rock-package_set#261).
The latest urdfdom release (3.0.0) doesn't include this breaking change yet, though.
For further reading: https://discourse.ros.org/t/upcoming-api-break-in-urdfdom/34750