-
Notifications
You must be signed in to change notification settings - Fork 2
Updating Readme.md to include public offer text and example. #20693 #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3e9db4c to
be6bb86
Compare
|
Closed the PR after approved. |
|
@AndreaCuneo Jose's feature's merge is blocked. The pull request's build fails with error HttpError: Resource not accessible by integration. I don't really know what that means or how to resolve it. The feature branch is in Jose's repo not the ARKLab repo, so I wonder if that's an issue. I don't have permissions to look at the Artesian.SDK repo's options so I don't know if Jose's permissions are different to other team members. Do you have any idea how to resolve the build issues. When that's done will the merge be enabled? |
|
@PeterRimmer71 I don't know exactly. The error is related to Github workflow permissions. I know that when running workflows from forks some more settings are required so is likely related to that. We don't expect much external contributions atm. You can either study the issue and resolve the support for fork contributions or José has to do the PR in the usual, supported way. |
|
|
@Jose-Ark looks like you missed the Organization invitation I sent you month ago. I've reinvited you now. |

Updating the example for public offers due to the change to the GME Public Offer persistence to Azure Storage. Also explain in the text that requesting narrow subsets (e.g., a single status or offerType) does not improve performance and can cause the service to fetch the same dataset multiple times due to the underlying storage layout.