Soft-deprecate GNU_PROPERTY_AARCH64_FEATURE_1_PAC #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@smithp35 @DanielKristofKiss FYI clarifying the meaning of the PAC program property. |
smithp35
reviewed
Dec 6, 2021
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
Thanks for the update. A couple of small suggestions.
pbarrio
force-pushed
the
DeprecatePACProperty
branch
from
b80e9ed to
220f98a
Compare
Users should not rely on this property to enquire about the status of the protection of an ELF file. If it is present, then yes, the file has been protected. If it is not present, it can still have been protected to some extent. The comment on Custom PLT protection has also been removed. This protection is seen as a separate feature to PAC-ret, since you could ask the linker to generate protected PLTs regardless of the presence of PAC-ret.
pbarrio
force-pushed
the
DeprecatePACProperty
branch
from
220f98a to
1fd7e96
Compare
Contributor
Author
|
@smithp35 I updated a new patch with your two suggestions. |
smithp35
approved these changes
Dec 9, 2021
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update.
| executable sections have been protected with Return Address Signing. | ||
| Its use is optional, meaning that an ELF file where this feature bit | ||
| is unset can still have Return Address signing enabled in some or all | ||
| its executable sections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not rely on this property to enquire about the status
of the protection of an ELF file. If it is present, then yes, the
file has been protected. If it is not present, it can still have
been protected to some extent.
The comment on Custom PLT protection has also been removed. This
protection is seen as a separate feature to PAC-ret, since you could
ask the linker to generate protected PLTs regardless of the presence
of PAC-ret.