[CLIBABI32] Restore missing reference to EDOM. #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just noticed a paragraph that was grammatically confusing because it contained a comma with no word before it, and an equality with no left-hand side. It looks to me as if the <errno.h> macro name EDOM was accidentally deleted in both cases. (Rationale: EDOM is an error code closely related to ERANGE, and matches the claim in the paragraph that its consensus value is 33 – that's its value on Linux, for example.) Searching for ERANGE in the rest of the document turned up another two places where there was a missing word that looked as if it ought to be "EDOM". I've no idea how this happened! But it seems like an easy fix.
smithp35
approved these changes
Mar 21, 2024
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM
I agree this looks like a typo. The MS documentation for EDOM is also 33 https://learn.microsoft.com/en-us/cpp/c-runtime-library/errno-constants?view=msvc-170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed a paragraph that was grammatically confusing because it contained a comma with no word before it, and an equality with no left-hand side.
It looks to me as if the <errno.h> macro name EDOM was accidentally deleted in both cases. (Rationale: EDOM is an error code closely related to ERANGE, and matches the claim in the paragraph that its consensus value is 33 – that's its value on Linux, for example.)
Searching for ERANGE in the rest of the document turned up another two places where there was a missing word that looked as if it ought to be "EDOM".
I've no idea how this happened! But it seems like an easy fix.