Skip to content

Conversation

@kmclaughlin-arm
Copy link
Contributor

No description provided.

@smithp35 smithp35 requested a review from rsandifo-arm May 23, 2024 15:33
Copy link
Contributor

@rsandifo-arm rsandifo-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think it'd be worth mentioning this change in the change history table.

@rsandifo-arm rsandifo-arm merged commit 5c0a393 into ARM-software:main May 29, 2024
kmclaughlin-arm added a commit to kmclaughlin-arm/llvm-project that referenced this pull request May 30, 2024
  ARM-software/abi-aa#263
  - Renamed get_runtime_vl to __arm_get_current_vg
  - Also return VG if currently in streaming-mode

- Added static to get_aarch64_cpu_features

- Added aarch64.h and included in sme-abi-init.c
kmclaughlin-arm added a commit to kmclaughlin-arm/llvm-project that referenced this pull request May 31, 2024
Adds a calling convention for calls to the __arm_get_current_vg support
routine, which preserves X1-X15, X19-X29, SP, Z0-Z31 & P0-P15.

See ARM-software/abi-aa#263
kmclaughlin-arm added a commit to kmclaughlin-arm/llvm-project that referenced this pull request Jun 5, 2024
Adds a calling convention for calls to the __arm_get_current_vg support
routine, which preserves X1-X15, X19-X29, SP, Z0-Z31 & P0-P15.

See ARM-software/abi-aa#263
kmclaughlin-arm added a commit to llvm/llvm-project that referenced this pull request Jun 6, 2024
Adds a calling convention for calls to the `__arm_get_current_vg`
support
routine, which preserves X1-X15, X19-X29, SP, Z0-Z31 & P0-P15.

See ARM-software/abi-aa#263
**(Beta)**

Platforms that support SME must provide a subroutine to query the current
value of VG, with the subroutine having the following properties:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to:

and the subroutine must have the following properties:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by #278

Copy link

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants