[LSFE] Correct change 9f262a0c7 to preserve S1 (val) in example code #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend change 9f262a0 to preserve S1 (`val`) in the example code, which was overwritten if the final write failed. Also format the change history correctly.
smithp35
approved these changes
Mar 4, 2025
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the update. Apologies for not spotting on the first review.
Contributor
|
Strictly speaking there is nothing that says that 'val' is either valid or returned after the operation. So either version works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend change 9f262a0 to preserve S1 (
val) in the example code, which was overwritten if the final write failed. Also format the change history correctly.