Skip to content

fix: normalize network boot fail reasons to lists #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Apr 21, 2026
Merged

fix: normalize network boot fail reasons to lists #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions common/log_parser/standalone_tests/logs_to_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,7 @@ def parse_network_boot_log(log_data):
status = match_explicit.group(2).strip()
reason = match_explicit.group(3).strip() if match_explicit.group(3) else ""

# Create subtest with string reasons instead of arrays
# Create subtest with reason lists to match other parsers
subtest = {
"sub_Test_Number": str(subtest_number),
"sub_Test_Description": test_name,
Expand All @@ -1242,12 +1242,12 @@ def parse_network_boot_log(log_data):
}
}

# Add reason as string (not array) only if present
# Add reason as list to keep downstream waiver logic consistent
if reason:
if status == "PASSED":
subtest["sub_test_result"]["pass_reasons"] = reason
subtest["sub_test_result"]["pass_reasons"] = [reason]
elif status == "FAILED":
subtest["sub_test_result"]["fail_reasons"] = reason
subtest["sub_test_result"]["fail_reasons"] = [reason]

current_test["subtests"].append(subtest)
current_test["test_suite_summary"][f"total_{status.lower()}"] += 1
Expand Down
Loading