pr #387 ('su -c') seems to break command execution for me

[v0lker]

#387 moves from echo <command> | su to su -c <command>

su doesn't know about the -c option, at least on my test platform with an android q preview, which uses android's own system/extras/su/su.cpp

evil_platform:/ # which su
/system/xbin/su

and that's the only one.. on that machine.

[marcbonnici]

Would you be able to provide the version of su that you are using and also the error output that attempting to use that parameter produces?

[v0lker]

i'm using a different version but visually, it looks like this one: https://android.googlesource.com/platform/system/extras/+/refs/tags/android-q-preview-5/su/su.cpp

the error message is su: invalid uid/gid '-c'

[marcbonnici]

A fallback mechanism has been added with #409, would you be able to try this out and see if it resolves your issue?

[v0lker]

thanks, that seems to work for me:

[ins] In [6]: a = devlib.AndroidTarget(working_directory=s)
[...]
[ins] In [8]: a.execute("whoami")         
Out[8]: 'shell\n'

[ins] In [9]: a.execute("whoami", as_root=True)                                     
Out[9]: 'root\n'