LocalLinuxTarget: fix executables folder location #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derkling
force-pushed
the
fix-local_linux_target
branch
from
1c04a0c to
08c4b95
Compare
derkling
changed the title
setrofim
approved these changes
Jan 16, 2018
marcbonnici
approved these changes
Jan 16, 2018
Collaborator
marcbonnici
left a comment
marcbonnici
left a comment
There was a problem hiding this comment.
"used used" and "deafult" -> "default" in commit message.
Since: cafc0a4 target: do not create shutil in package directory we generate 'shutils' in /tmp, which is also the executables_path used by default by a LocalLinuxTarget. This ultimately results into a: self.install(shutils_ofile) ... shutil.copy(source, dest) raising an exception since source == dest. Let's fix this by setting /tmp/devlib-target as a default base path for all devlib deployed stuff into a localhost target. Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
derkling
force-pushed
the
fix-local_linux_target
branch
from
08c4b95 to
8332fd6
Compare
Contributor
Author
|
Update to address comments on commit message's typos ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
cafc0a4 target: do not create shutil in package directory
we generate 'shutils' in /tmp, which is also the executables_path
used used by deafult by a LocalLinuxTarget.
This ultimately results into a:
self.install(shutils_ofile)
...
shutil.copy(source, dest)
raising an exception since source == dest.
Let's fix this by setting /tmp/devlib-target as a default base path for
all devlib deployed stuff into a localhost target.
Signed-off-by: Patrick Bellasi patrick.bellasi@arm.com