Skip to content

connection: Make BackgroundCommand.wait() return non-None #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
douglas-raillard-arm wants to merge 1 commit into from
Closed

connection: Make BackgroundCommand.wait() return non-None #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions devlib/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def send_signal(self, sig):
:type signal: signal.Signals
"""
try:
self._send_signal(signal.SIGKILL)
return self._send_signal(signal.SIGKILL)
finally:
# Deregister if the command has finished
self.poll()
Expand All @@ -188,7 +188,7 @@ def cancel(self, kill_timeout=_KILL_TIMEOUT):
"""
try:
if self.poll() is None:
self._cancel(kill_timeout=kill_timeout)
return self._cancel(kill_timeout=kill_timeout)
finally:
self._deregister()

Expand All @@ -208,7 +208,7 @@ def wait(self):
Block until the background command completes, and return its exit code.
"""
try:
self._wait()
return self._wait()
finally:
self._deregister()

Expand Down