Fix __del__ excep #685
Merged
Fix __del__ excep #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow cleanly disconnecting the Target object, so that we don't get garbage output from __del__ later on when half of the namespace has already disappeared.
Ensure the connections that Target.disconnect() closes do not stay around in case the Target object is later reused.
Use atexit handler to run Target.disconnect() when the process is about to exit. This avoids running it with a half torn down namespace, with ensuing exceptions and non-clean disconnect.
Collaborator
Author
|
PR updated to also disconnect upon process exit, before the modules are torn down. This should prevent getting exceptions logged in |
marcbonnici
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684
This PR is untested for now.