Skip to content

Fix the return type to psa_pake_cs_get_hash() #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
athoelke wants to merge 1 commit into from
Closed

Fix the return type to psa_pake_cs_get_hash() #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/ext-pake/api.db/psa/crypto-pake.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: Copyright 2018-2022 Arm Limited and/or its affiliates <open-source-office@arm.com>
// SPDX-FileCopyrightText: Copyright 2018-2023 Arm Limited and/or its affiliates <open-source-office@arm.com>
// SPDX-License-Identifier: Apache-2.0

typedef /* implementation-defined type */ psa_pake_cipher_suite_t;
Expand Down Expand Up @@ -33,7 +33,7 @@ typedef uint8_t psa_pake_step_t;
psa_status_t psa_pake_abort(psa_pake_operation_t * operation);
psa_pake_cipher_suite_t psa_pake_cipher_suite_init(void);
psa_algorithm_t psa_pake_cs_get_algorithm(const psa_pake_cipher_suite_t* cipher_suite);
psa_pake_primitive_t psa_pake_cs_get_hash(const psa_pake_cipher_suite_t* cipher_suite);
psa_algorithm_t psa_pake_cs_get_hash(const psa_pake_cipher_suite_t* cipher_suite);
psa_pake_primitive_t psa_pake_cs_get_primitive(const psa_pake_cipher_suite_t* cipher_suite);
void psa_pake_cs_set_algorithm(psa_pake_cipher_suite_t* cipher_suite,
psa_algorithm_t alg);
Expand Down
2 changes: 1 addition & 1 deletion doc/ext-pake/api/pake.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ A PAKE cipher suite is required when setting up a PAKE operation in `psa_pake_se
.. param:: const psa_pake_cipher_suite_t* cipher_suite
The cipher suite object to query.

.. return:: psa_pake_primitive_t
.. return:: psa_algorithm_t
The hash algorithm stored in the cipher suite object.
The return value is :code:`PSA_ALG_NONE` if the PAKE is not parametrized by a hash algorithm, or if the hash algorithm is not set.

Expand Down
5 changes: 3 additions & 2 deletions doc/ext-pake/appendix/history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ This section provides the detailed changes made between published version of the
Changes between *Beta 1* and *Beta 2*
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Clarifications
~~~~~~~~~~~~~~
Clarifications and bug fixes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Clarified the behavior of the PAKE operation following a call to `psa_pake_setup()`.
* Fixed the return type to `psa_pake_cs_get_hash()`.

Changes between *Beta 0* and *Beta 1*
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down