Skip to content

Move PAKE hash parameter to the PAKE algorithm identifier#124

Merged
athoelke merged 1 commit intoARM-software:mainfrom
athoelke:pake-SIZE-macros-v2
Nov 29, 2023
Merged

Move PAKE hash parameter to the PAKE algorithm identifier#124
athoelke merged 1 commit intoARM-software:mainfrom
athoelke:pake-SIZE-macros-v2

Conversation

@athoelke
Copy link
Copy Markdown
Contributor

This is alternate approach to #116, in response to issue #88.

  • Moved the hash algorithm parameter for a PAKE cipher suite into the PAKE algorithm identifier, instead of storing a separate attribute of the cipher suite.
    • Updated the PAKE algorithm encoding
    • Updated the J-PAKE algorithm macro, and added PSA_ALG_IS_JPAKE()
    • Removed the cipher suite accessors for the hash algorithm
  • This also makes the hash algorithm value available to the PSA_PAKE_OUTPUT_SIZE() and PSA_PAKE_INPUT_SIZE() macros.

Fixes #88

@athoelke athoelke added enhancement New feature or request API design Related the design of the API Crypto API Issue or PR related to the Cryptography API labels Nov 13, 2023
@athoelke athoelke self-assigned this Nov 13, 2023
@athoelke
Copy link
Copy Markdown
Contributor Author

Feedback appreciated from @silabs-Kusumit, @silabs-hannes, @oberon-sk, and @yanesca.

@silabs-Kusumit
Copy link
Copy Markdown

I think this is a better solution to #88 than #116.

LGTM

* Moved the hash algorithm parameter to the PAKE cipher suite into the PAKE algorithm identifier, instead of a separate attribute of the cipher suite.
* This also makes the hash algorithm value available to the `PSA_PAKE_OUTPUT_SIZE()` and `PSA_PAKE_INPUT_SIZE()` macros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API design Related the design of the API Crypto API Issue or PR related to the Cryptography API enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

PAKE SIZE macros need more arguments

2 participants