Skip to content

fix(pcie): PCI_IN_13 test checks UR completion, not all-1s data #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
May 8, 2026
Merged

fix(pcie): PCI_IN_13 test checks UR completion, not all-1s data #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions test_pool/pcie/p004.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ payload(void)
uint64_t ori_mem_base = 0;
uint64_t mem_lim = 0, new_mem_lim = 0;
uint32_t status;
uint32_t ur_status;
pcie_device_bdf_table *bdf_tbl_ptr;

tbl_index = 0;
Expand Down Expand Up @@ -212,7 +213,7 @@ payload(void)
continue;
}

/**Check_2: Accessing out of NP memory limit range must return 0xFFFFFFFF
/**Check_2: Accessing out of NP memory limit range must result in UR completion
*
* If the limit exceeds 1MB then modify the range to be 1MB
* and access out of the limit set
Expand All @@ -228,15 +229,19 @@ payload(void)
val_pcie_read_cfg(bdf, TYPE1_NP_MEM, &read_value);

val_pcie_bar_mem_read(bdf, new_mem_lim + MEM_OFFSET_SMALL, &value);
val_print(DEBUG, " Value read is 0x%llx", value);
if (value != PCIE_UNKNOWN_RESPONSE)
ur_status = val_pcie_is_urd(bdf);
val_print(DEBUG, " Value read is 0x%llx, UR status is %d", value, ur_status);
if (!ur_status)
{
val_print(ERROR, "\n Memory range for bdf 0x%x", bdf);
val_print(ERROR, " is 0x%x", read_value);
val_print(ERROR,
"\n Out of range 0x%x", (new_mem_lim + MEM_OFFSET_SMALL));
"\n UR response not obtained for out of range access on bdf 0x%x", bdf);
val_print(ERROR, " Range register value 0x%x", read_value);
val_print(ERROR, "\n Out of range 0x%llx",
(new_mem_lim + MEM_OFFSET_SMALL));
val_set_status(pe_index, RESULT_FAIL(03));
}

val_pcie_clear_urd(bdf);
}

exception_return:
Expand Down
19 changes: 12 additions & 7 deletions test_pool/pcie/p005.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ payload(void)
uint32_t read_value, value;
uint32_t old_value, new_value;
uint32_t status;
uint32_t ur_status;
uint32_t test_skip = 1;
uint32_t mem_offset = 0;
uint64_t mem_base = 0, mem_base_upper = 0, ori_mem_base = 0;
Expand Down Expand Up @@ -225,7 +226,7 @@ payload(void)
continue;
}

/**Check_2: Accessing out of P memory limit range must return 0xFFFFFFFF
/**Check_2: Accessing out of P memory limit range must result in UR completion
*
* If the limit exceeds 1MB then modify the range to be 1MB
* and access out of the limit set
Expand Down Expand Up @@ -261,16 +262,20 @@ payload(void)
updated_mem_lim |= (mem_lim_upper << P_MEM_LU_SHIFT);

val_pcie_bar_mem_read(bdf, new_mem_lim + MEM_OFFSET_SMALL, &value);
val_print(DEBUG, " Value read is 0x%llx", value);
if (value != PCIE_UNKNOWN_RESPONSE)
ur_status = val_pcie_is_urd(bdf);
val_print(DEBUG, " Value read is 0x%llx, UR status is %d", value, ur_status);
if (!ur_status)
{
val_print(ERROR, "\n Memory range for bdf 0x%x", bdf);
val_print(ERROR, " is 0x%llx", updated_mem_base);
val_print(ERROR, " 0x%llx", updated_mem_lim);
val_print(ERROR,
"\n Out of range 0x%llx", (new_mem_lim + MEM_OFFSET_SMALL));
"\n UR response not obtained for out of range access on bdf 0x%x", bdf);
val_print(ERROR, " Range 0x%llx - 0x%llx",
updated_mem_base, updated_mem_lim);
val_print(ERROR, "\n Out of range 0x%llx",
(new_mem_lim + MEM_OFFSET_SMALL));
val_set_status(pe_index, RESULT_FAIL(03));
}

val_pcie_clear_urd(bdf);
}

exception_return:
Expand Down
Loading