fix(pal/uefi_acpi): update MemoryMapSize after memory map allocation#396
Merged
Conversation
Recompute MemoryMapSize from the allocated page count before retrying GetMemoryMap. This keeps the buffer size passed to GetMemoryMap aligned with the actual allocation size after AllocatePages succeeds. Previously, the retry path allocated memory based on the required page count but continued using the earlier MemoryMapSize value. Updating it with EFI_PAGES_TO_SIZE(Pages) ensures the firmware receives the correct buffer size for the allocated memory map buffer. Signed-off-by: Rajat Goyal <rajat.goyal@arm.com> Change-Id: I9ceaac06f73aee6797c225ea540d502095390d99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recompute MemoryMapSize from the allocated page count before retrying
GetMemoryMap. This keeps the buffer size passed to GetMemoryMap aligned
with the actual allocation size after AllocatePages succeeds.
Previously, the retry path allocated memory based on the required page
count but continued using the earlier MemoryMapSize value. Updating it
with EFI_PAGES_TO_SIZE(Pages) ensures the firmware receives the correct
buffer size for the allocated memory map buffer.
Fixes #357
Change-Id: I9ceaac06f73aee6797c225ea540d502095390d99