Skip to content

fix(pcie): skip non-prefetchable BARs in P094 flow#398

Merged
chetan-rathore merged 1 commit into
ARM-software:mainfrom
Sujana-M:main
May 13, 2026
Merged

fix(pcie): skip non-prefetchable BARs in P094 flow#398
chetan-rathore merged 1 commit into
ARM-software:mainfrom
Sujana-M:main

Conversation

@Sujana-M
Copy link
Copy Markdown
Collaborator

@Sujana-M Sujana-M commented May 12, 2026

  • add BAR_MEM macro to detect non-prefetchable BAR type
  • skip NP BARs and check only for Prefetch bars to avoid any side effects
  • Mask the last 4 bits of the BAR value as it points to the attributes.
  • Skip cndition to be verified first before checking the warn condition.
  • Map Prefetch bar of base+32MB as most platforms map below 32MB to mapped to control registers, lookup tables, or routing tables.
  • The endpoint check is incorrectly checked as a result only first 2 BARS were checked. Updated to check the right return type.
  • When first BAR is 0, skipping to next BDF, instead of next bar, updated the changes accordingly to check for next bdf
  • Replaced %.*x precision prints to zero padding prints
  • Changed the SBSA Header prints from ERROR to INFO, as in logs it is considered as error
  • Relates Inquiry about validity of PCIe BAR mapping in PCI_MM_01 vs. PCI_MM_03 #282

Change-Id: Ieaa6609814cd25efb6495d8b5a77d4da73eabfea

- add BAR_MEM macro to detect non-prefetchable BAR type
- skip NP BARs and check only for Prefetch bars to avoid any side effects
- Mask the last 4 bits of the BAR value as it points to the attributes.
- Skip cndition to be verified first before checking the warn condition.
- Map Prefetch bar of base+32MB as most platforms map below 32MB to
  mapped to control registers, lookup tables, or routing tables.
- The endpoint check is incorrectly checked as a result only first 2
  BARS were checked. Updated to check the right return type.
- When first BAR is 0, skipping to next BDF, instead of next bar,
  updated the changes accordingly to check for next bdf
- Replaced %.*x precision prints to zero padding prints
- Changed the SBSA Header prints from ERROR to INFO, as in logs it is
  considered as error
- Fixes ARM-software#282

Signed-off-by: Sujana M <sujana.murali@arm.com>
Change-Id: Ieaa6609814cd25efb6495d8b5a77d4da73eabfea
@chetan-rathore chetan-rathore merged commit 0a61cfd into ARM-software:main May 13, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants