-
Notifications
You must be signed in to change notification settings - Fork 0
Sequence groupings #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import unittest | ||
|
|
||
| from watergrid.context import DataContext | ||
| from watergrid.pipelines.pipeline import Pipeline | ||
| from watergrid.steps import Sequence | ||
| from watergrid.steps import Step | ||
|
|
||
|
|
||
| class MockStep(Step): | ||
| def __init__(self): | ||
| super().__init__("mock_step") | ||
| self.flag = False | ||
|
|
||
| def run(self, context: DataContext): | ||
| self.flag = True | ||
|
|
||
| def get_flag(self) -> bool: | ||
| return self.flag | ||
|
|
||
|
|
||
| class TestSequence(Sequence): | ||
| def __init__(self): | ||
| super().__init__("test_sequence") | ||
|
|
||
|
|
||
| class SequenceTestCase(unittest.TestCase): | ||
| def test_sequence_adds_steps(self): | ||
| pipeline = Pipeline("test_pipeline") | ||
| mock_step = MockStep() | ||
| sequence = TestSequence() | ||
| sequence.add_step(mock_step) | ||
| pipeline.add_steps(sequence) | ||
| pipeline.run() | ||
| self.assertTrue(mock_step.get_flag()) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| from watergrid.steps.step import Step | ||
| from watergrid.steps.sequence import Sequence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from abc import ABC | ||
|
|
||
| from watergrid.steps import Step | ||
|
|
||
|
|
||
| class Sequence(ABC): | ||
| """ | ||
| A sequence object is used to form a logical grouping of steps. It can be | ||
| used to simplify your pipeline initialization code, or it can be used to | ||
| rapidly re-use multiple steps at once. | ||
| """ | ||
|
|
||
| def __init__(self, name: str): | ||
| self.name = name | ||
| self.steps = [] | ||
|
|
||
| def add_step(self, step: Step) -> None: | ||
| """ | ||
| Adds a step to the sequence. | ||
| :param step: Step to add. | ||
| :return: None | ||
| """ | ||
| self.steps.append(step) | ||
|
|
||
| def export_steps(self) -> list: | ||
| """ | ||
| Returns a list of all steps in the sequence. Used internally by the | ||
| pipeline class. | ||
| :return: List of all steps. | ||
| """ | ||
| return self.steps |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.