Skip to content

fix flash algo generation script#946

Merged
mbrossard merged 1 commit into
ARMmbed:developfrom
zjli-2019:fix_flash_algo_script
Feb 12, 2023
Merged

fix flash algo generation script#946
mbrossard merged 1 commit into
ARMmbed:developfrom
zjli-2019:fix_flash_algo_script

Conversation

@zjli-2019
Copy link
Copy Markdown

  1. generate #define instead of const uint32_t;
  2. add the missing field algo_flags.

@mbrossard
Copy link
Copy Markdown
Contributor

It's not clear to me what you are trying to fix. I don't see any targets using FLASH_START / FLASH_SIZE. flash_start and flash_size might be problematic, but macros are not the solutions. I would rather add the region size to sectors_info but this is a larger project.

Making the flags explicit would be cleaner.

@zjli-2019
Copy link
Copy Markdown
Author

  1. A possible use case of flash_start and flash_size:

    target_cfg_t target_device = {
        .sectors_info                   = sectors_info,
        .sector_info_length             = (sizeof(sectors_info))/(sizeof(sector_info_t)),
        .flash_regions[0].start         = flash_start,
        .flash_regions[0].end           = flash_start + flash_size,
        //...
  2. flags is supposed to be edited manually later, which is not the best solution, but slightly better than none.

Add the missing field `algo_flags`
@mbrossard mbrossard force-pushed the fix_flash_algo_script branch from 516a273 to 478b72b Compare February 12, 2023 03:56
@mbrossard mbrossard changed the base branch from main to develop February 12, 2023 03:57
@mbrossard mbrossard merged commit 9f83e78 into ARMmbed:develop Feb 12, 2023
jnthbdn pushed a commit to letssteam/DAPLink that referenced this pull request Jun 6, 2024
jnthbdn pushed a commit to letssteam/DAPLink that referenced this pull request Jun 6, 2024
jnthbdn pushed a commit to letssteam/DAPLink that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants