Skip to content

Reorder callbacks by their latest executable time#34

Open
LiyouZhou wants to merge 1 commit intoARMmbed:masterfrom
LiyouZhou:reorder_by_late_exe_t
Open

Reorder callbacks by their latest executable time#34
LiyouZhou wants to merge 1 commit intoARMmbed:masterfrom
LiyouZhou:reorder_by_late_exe_t

Conversation

@LiyouZhou
Copy link
Copy Markdown
Contributor

i.e. by scheduled_time + tolerance

i.e. by scheduled_time + tolerance
@bogdanm
Copy link
Copy Markdown
Contributor

bogdanm commented Feb 29, 2016

As explained before, I'm hesitant to merge this kind of change before the release, since it might break people's code (see the issue you're working on with Marcelo) and it would require a new major version. It feels too hasty before an official release.
Cc @bremoran though.

@LiyouZhou
Copy link
Copy Markdown
Contributor Author

@bogdanm I'm ok with postponing merge. I just want this to be on record for discussions.

@bogdanm
Copy link
Copy Markdown
Contributor

bogdanm commented Feb 29, 2016

That's perfectly fine then, thanks.

@bremoran
Copy link
Copy Markdown
Contributor

Maybe I don't understand what this PR is supposed to do. My understanding is that call_before is already supposed to include the tolerance of the callback. This looks like we are now including double the tolerance: https://github.com/ARMmbed/minar/pull/34/files#diff-7b622de8de42474bad104c534c61d2c2R260

I'd like to see some measurements to demonstrate that this is doing the right thing.

@LiyouZhou
Copy link
Copy Markdown
Contributor Author

@LiyouZhou
Copy link
Copy Markdown
Contributor Author

A simple test was written to demonstrate and test the functionality. https://github.com/ARMmbed/minar-tests/blob/reordering_tests/test/MINAR037_tolerance_based_reordering.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants