Skip to content

new shuffle feature#227

Closed
walthierer wants to merge 2 commits intodevelopmentfrom
shuffle_feature
Closed

new shuffle feature#227
walthierer wants to merge 2 commits intodevelopmentfrom
shuffle_feature

Conversation

@walthierer
Copy link
Member

Revised the module.js file to enable different displays of the modules after the website is reloaded.

@walthierer walthierer requested a review from timmwille January 27, 2026 16:48
@walthierer walthierer added feature New feature or request JavaScript labels Jan 27, 2026
@timmwille
Copy link
Member

I think this change has too many changes, that are not only aiming at the shuffle mode. It changes the internal structure of the platform view and caching/saving the selection. I am not 100% sure how to fix that properly, might be due to not up to date branch?

@saisilinus could you have a quick look on this

@timmwille timmwille marked this pull request as draft January 27, 2026 17:09
@saisilinus
Copy link
Collaborator

Please add a description for the PR @walthierer. You can use this template as a guideline:

Pull Request

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@timmwille
Copy link
Member

timmwille commented Jan 28, 2026

good Idea with #229 ... for now if you could help implementing a set switch button to "shuffle" would be awesome @saisilinus - I think this way one can still switch to "regular" unshuffled mode if needed

You can use the feature branch @walthierer created

@saisilinus
Copy link
Collaborator

Ok

@timmwille
Copy link
Member

I think I found a good compromise, thx for the contribution @saisilinus and your suggestion to add this feature @walthierer

See: #231

lets keep the feature branch for reference

@timmwille timmwille closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request JavaScript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants