Skip to content

chore: User to Organization Mapping#48

Merged
cbolles merged 4 commits intomainfrom
chore/cbolles/user-to-organization
Feb 12, 2024
Merged

chore: User to Organization Mapping#48
cbolles merged 4 commits intomainfrom
chore/cbolles/user-to-organization

Conversation

@cbolles
Copy link
Contributor

@cbolles cbolles commented Feb 12, 2024

  • Store UserOrg model
  • Have organization as request header
  • Dedicated Organization Guard

Incomplete

  • Have organization selection in UI

@cbolles cbolles requested a review from mannyakosah February 12, 2024 21:15
Copy link
Collaborator

@mannyakosah mannyakosah Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you wanna add a TODO comment of what the function "validate" is supposed to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the organization logic shifted, it is actually all it has to do now. It seems funky, but you'll see similar functionality in NestJS's official documentation. The validation is just for additional logic beyond the JWT validation.

@cbolles cbolles merged commit 0b4f753 into main Feb 12, 2024
@cbolles cbolles deleted the chore/cbolles/user-to-organization branch February 12, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants