[Logic] Refactor ShouldExcludeFromTooltip #2226
Open
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elper function to perform the same logic [Parser] Adjusted Function Template 'GenerateShouldExcludeFromTooltipForBuffs' to work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a field that calls another field which runs a helper function to recurse upwards in hierarchy to repeat the process.
If we consolidate the
ShouldExcludeFromTooltipbase field to perform the recursion and let overrides ofShouldExcludeFromTooltipdetermine whether that recursion should persist if their own implementation is not met, we get the exact same logic flow without the multiple extra chained steps.I just don't have a way to fully test the custom
ShouldExcludeFromTooltipfunctionality in MoP Classic concerning the different dungeon 'Protocol X' buffs. If someone on Classic with high-level characters could:Parser for Classic (05 - Mists of Pandaria).batThen we can merge this in. The OnInit part of the FunctionTemplate change works fine, it's just the actual execution of the ShouldExcludeFromTooltip functionality while within a dungeon for an NPC with/without the respective Buff being active that I can't test myself.