feat(decor): fix edge case where placed decor is marked uncollected #2233
+28
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t marked as collected, due to weird blizzapi shenanigans
Contributor
Author
|
should note this also correctly catches instances where you destroy the only instance of decor, but this seems to also be wrapped in some weird blizz bug as the housing UI itself doesn't update until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to stem from some weird blizz shenanigans where
C_Housing.GetCatalogEntryInfoByRecordIDnever properly returns anumPlacedfor decor that i've placed but have 0 in storage.looking through the blizz ui code, it looks like it all uses the housing searcher API +
C_HousingCatalog.GetCatalogEntryInfo.using this version of Decor.lua collected ~20 things for me that i owned but weren't showing as collected as they had been placed. some of these were vendor items, others crafted, etc.
the other option would be to rewrite the existing code to derive the correct function, but
GetCatalogEntryInforequires a struct with extra data that i'm unsure how to get.