Skip to content

Conversation

@BryceGattis
Copy link
Contributor

@BryceGattis BryceGattis commented May 15, 2025

Update package cache to respect external logging.

Closes #1879.

@BryceGattis BryceGattis requested a review from a team as a code owner May 15, 2025 12:25
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.02%. Comparing base (be6dc49) to head (d46342e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage   60.01%   60.02%           
=======================================
  Files         163      163           
  Lines       20113    20118    +5     
  Branches     3505     3506    +1     
=======================================
+ Hits        12070    12075    +5     
  Misses       7223     7223           
  Partials      820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

BryceGattis and others added 5 commits May 15, 2025 09:52
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
…s only set after Python 3.8 apparently

Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BryceGattis! I think the test could potentially be improved, but I'm ok with it for now.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added the devdays25 ASWF Dev Days 2025 label May 19, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone May 19, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title PackageCache respect external logging Use REZ_LOGGING_CONF in package payload cache daemon May 19, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 6608c03 into AcademySoftwareFoundation:main May 19, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devdays25 ASWF Dev Days 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PackageCache Class to respect external logging configuration

2 participants