-
Notifications
You must be signed in to change notification settings - Fork 357
Improve package repository case insensitive error handling #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve package repository case insensitive error handling #1974
Conversation
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
+ Coverage 60.07% 60.11% +0.04%
==========================================
Files 163 163
Lines 20096 20098 +2
Branches 3493 3494 +1
==========================================
+ Hits 12072 12082 +10
+ Misses 7208 7205 -3
+ Partials 816 811 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Bryce Gattis <36783788+BryceGattis@users.noreply.github.com>
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Bryce Gattis <36783788+BryceGattis@users.noreply.github.com>
|
@JeanChristopheMorinPerso One thing that I could use some help on, from poking around, I expected that adding this new test file would allow me to do Looking at selftest, it should be autogenerated as a new flag. Do you have any idea why it's not working? |
…olders Signed-off-by: BryceGattis <brycegattis@yahoo.com>
…//github.com/BryceGattis/rez into hotfix/create_variant_case_mismatch_handling
|
@BryceGattis They should appear in |
It was due to a typo in the filename 🤦 |
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
dac6bcb
into
AcademySoftwareFoundation:main
Remake of the original PR #1951 on my personal GitHub.
Closes #1931.
This adds a new unit test for the fix as well.