Conversation
|
Sorry to intrude on your PR, but I have a question. Do you know if the following change is required as well? I suspect that maybe polkadot/substrate will automatically canonicalize it, in which case it doesn't matter, but tbh I am not completely sure where the new fn native_currency_location(id: CurrencyId) -> MultiLocation {
- MultiLocation::new(1, X2(Parachain(ParachainInfo::get().into()), GeneralKey(id.encode())))
+ MultiLocation::new(0, X1(GeneralKey(id.encode())))
} |
|
don't need change |
|
Another headsup: I found in kintsugi testing on rococo-local that we needed to canonicalize the chain-local assetids in the |
👍 I'll revisit Trader config, as we're missing transfer native asset test, previous I add some code but delete them as I need to add |
xcm related:
integration-testsfeature flag for now.also useintegration-teststo testcase which make sure RMRK migration works.removal Default:
ParentIsPreset (not sure new cumulus release will include this yet)client:
runtime new pallet:
add pallet_child_bounties to pallet_bounties(do not add for now as kusama runtime not added)tests:
kusama native asset: karura native asset test #1768current karura and sibling both use same runtime, so their native asset both is KAR, needintegration-teststo manual adapt/fixed the para_id to 2000upgrade guide:
(1, X2(1000, GenealIndex(8)))to(1, X3(1000, PalletInstance(50), GeneralIndex(8)))