Skip to content

Evm tests#1792

Merged
xlc merged 15 commits intomasterfrom
evm-tests
Jan 25, 2022
Merged

Evm tests#1792
xlc merged 15 commits intomasterfrom
evm-tests

Conversation

@ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Jan 17, 2022

@zjb0807
Copy link
Contributor

zjb0807 commented Jan 17, 2022

Why revert #1772?

@ermalkaleci
Copy link
Contributor Author

ermalkaleci commented Jan 17, 2022

Why revert #1772?

it will break evm-tests. we will need to go back and see what we can update after all tests been implemented

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1792 (8c460de) into master (01a2dea) will decrease coverage by 0.19%.
The diff coverage is 15.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   85.63%   85.44%   -0.20%     
==========================================
  Files          75       77       +2     
  Lines       16529    16961     +432     
==========================================
+ Hits        14155    14492     +337     
- Misses       2374     2469      +95     
Impacted Files Coverage Δ
modules/evm/src/lib.rs 63.67% <0.00%> (ø)
primitives/src/evm.rs 93.75% <ø> (ø)
primitives/src/lib.rs 88.57% <0.00%> (-11.43%) ⬇️
modules/evm/src/runner/state.rs 53.33% <5.88%> (+3.02%) ⬆️
modules/evm/src/runner/stack.rs 53.01% <22.72%> (-2.04%) ⬇️
modules/evm/src/tests.rs 99.21% <100.00%> (ø)
modules/nft/src/tests.rs
modules/nft/src/lib.rs
modules/currencies/src/lib.rs 80.10% <0.00%> (ø)
rpc/src/lib.rs 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a2dea...8c460de. Read the comment docs.

@ermalkaleci ermalkaleci marked this pull request as ready for review January 24, 2022 19:24
@ermalkaleci ermalkaleci requested review from ferrell-code, xlc and zjb0807 and removed request for zjb0807 January 24, 2022 20:36
@xlc xlc merged commit 6bb9204 into master Jan 25, 2022
@xlc xlc deleted the evm-tests branch January 25, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants