Merged
Conversation
xlc
reviewed
Feb 23, 2024
Member
xlc
left a comment
There was a problem hiding this comment.
one issue is that this won't work well with indirect EVM calls. e.g. currency.trasnfer ERC20 asset
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2716 +/- ##
==========================================
- Coverage 66.73% 66.72% -0.01%
==========================================
Files 66 69 +3
Lines 9027 9326 +299
==========================================
+ Hits 6024 6223 +199
- Misses 3003 3103 +100 ☔ View full report in Codecov by Sentry. |
ermalkaleci
commented
Mar 19, 2024
ermalkaleci
commented
Mar 19, 2024
xlc
previously approved these changes
Mar 21, 2024
zjb0807
previously approved these changes
Mar 21, 2024
xlc
approved these changes
Mar 26, 2024
ermalkaleci
added a commit
that referenced
this pull request
Mar 27, 2024
ermalkaleci
added a commit
that referenced
this pull request
Mar 28, 2024
Contributor
Author
#2731 will address this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.