Skip to content

evm tracing#2716

Merged
ermalkaleci merged 14 commits intomasterfrom
evm-tracing
Mar 26, 2024
Merged

evm tracing#2716
ermalkaleci merged 14 commits intomasterfrom
evm-tracing

Conversation

@ermalkaleci
Copy link
Contributor

No description provided.

Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue is that this won't work well with indirect EVM calls. e.g. currency.trasnfer ERC20 asset

@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 9.67742% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 66.72%. Comparing base (b5b5a74) to head (04d23ce).
Report is 4 commits behind head on master.

Files Patch % Lines
modules/evm/src/runner/state.rs 13.04% 20 Missing ⚠️
modules/evm/src/runner/tracing.rs 0.00% 6 Missing ⚠️
primitives/src/evm.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
- Coverage   66.73%   66.72%   -0.01%     
==========================================
  Files          66       69       +3     
  Lines        9027     9326     +299     
==========================================
+ Hits         6024     6223     +199     
- Misses       3003     3103     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ermalkaleci ermalkaleci marked this pull request as ready for review March 19, 2024 19:57
@ermalkaleci ermalkaleci requested review from xlc and zjb0807 March 20, 2024 11:07
xlc
xlc previously approved these changes Mar 21, 2024
zjb0807
zjb0807 previously approved these changes Mar 21, 2024
@ermalkaleci ermalkaleci dismissed stale reviews from zjb0807 and xlc via c0fbdc7 March 25, 2024 13:17
@ermalkaleci ermalkaleci merged commit d3134db into master Mar 26, 2024
@ermalkaleci ermalkaleci deleted the evm-tracing branch March 26, 2024 07:05
ermalkaleci added a commit that referenced this pull request Mar 27, 2024
ermalkaleci added a commit that referenced this pull request Mar 28, 2024
@ermalkaleci
Copy link
Contributor Author

one issue is that this won't work well with indirect EVM calls. e.g. currency.trasnfer ERC20 asset

#2731 will address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants