Merged
Conversation
4 tasks
shunjizhan
approved these changes
Jun 22, 2022
|
linter in predeploy changed I can add the fix to this branch |
Contributor
|
We could wait for the release of the MandalaAddress utility for the update 🤔 Current updates use a version of the ADDRESS utility with unified addresses and should work until then |
Updated NFT example tests to conform to conform to the new ERC721 error messages.
Updated the Precompiled token example to use the MandalaAddress utility.
Updated the DEX example to use the MandalaAddress.
Updated the EVM example to use the MandalaAddress utility.
ThunderDeliverer
force-pushed
the
update-examples
branch
from
237c3ce to
85d3717
Compare
Updated the NFT test summary in the README to reflect the changes.
ThunderDeliverer
approved these changes
Jul 1, 2022
Contributor
ThunderDeliverer
left a comment
ThunderDeliverer
left a comment
There was a problem hiding this comment.
All of the examples have beed updated to use the MandalaAddress utility and are good to be merged 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #53