Fix operator precedence and unused variable lint errors in App.tsx

[Copilot]

Two static analysis errors in src/App.tsx: mixed ??/|| without explicit precedence grouping, and a declared-but-never-used variable.

Changes

• Line 261 – operator precedence: Wrap the ?? expression in parentheses so || applies to the result, not just the right operand of ??

  // Before
  custom_goal: goalOverride ?? assocGoal || undefined
  // After
  custom_goal: (goalOverride ?? assocGoal) || undefined

• Line 607 – unused variable: Rename categories → _categories to signal intentional non-use and suppress the lint error

  const _categories = [...new Set(templates.map(t => t.category))];

Original prompt

Fix the 2 remaining errors in src/App.tsx:

Error 1 - Line 261:

There's an expression mixing ?? and || operators that needs parentheses for proper precedence.

Fix: Add parentheses around the ?? part:

// Instead of:   valeur ?? default || autreChose
// Change to:    (valeur ?? default) || autreChose

Error 2 - Line 607:

The variable categories is declared but never used.

Fix: Rename the variable to _categories to indicate it's intentionally unused:

// Change:
const categories = [...new Set(templates.map(t => t.category))];

// To:
const _categories = [...new Set(templates.map(t => t.category))];

This pull request was created from Copilot chat.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
sora	Error		Feb 25, 2026 9:21pm

[Copilot]

Pull request overview

This PR fixes two lint/static analysis errors in src/App.tsx: one requiring explicit operator precedence for mixed ??/|| operators, and one for an unused variable declaration.

Changes:

• Added parentheses to clarify operator precedence in the custom_goal expression when invoking the 'associate' function
• Renamed unused categories variable to _categories to suppress the unused variable lint error

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The variable _categories is computed but never used. While prefixing with underscore suppresses the lint error, consider whether this computation is needed at all. If it was intended for future use (e.g., filtering or displaying categories), it should either be implemented or removed entirely to avoid unnecessary computation on every render of the MarketTab component.

If this variable is truly not needed, delete the line entirely rather than keeping dead code.

Suggested change

const _categories = [...new Set(templates.map(t => t.category))];

[Copilot]

The expression (goalOverride ?? assocGoal) || undefined will convert empty strings to undefined. This means if both goalOverride and assocGoal are empty strings, or if goalOverride is not provided and assocGoal is an empty string, the custom_goal will be undefined.

Verify this is the intended behavior. If empty strings should be preserved and sent to the API, use goalOverride ?? assocGoal instead. If empty values should be filtered out, the current implementation is correct.

Suggested change

	body: { repo_ids: sel, custom_goal: (goalOverride ?? assocGoal) || undefined },
	body: { repo_ids: sel, custom_goal: goalOverride ?? assocGoal },