🐛 Fix bug in function for removing suffix from string #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys 👋
This PR fixes a small bug which would generate
Localization..stringsfile instead ofLocalization.stringsfile when using the following configuration:{ "defaultFileName": "Localization.string", .... }The current setup seems to still support default file names with their extension included:
ACKLocalization/Sources/ACKLocalizationCore/ACKLocalization.swift
Line 206 in afd8e35
However, it only works properly if no extension is included (
"defaultFileName": "Localization"as in the example in README). If extension is specified a file with double dot is generated. This is due to theremovingSuffixfunction only removingsuffix.count-1last characters of the string instead ofsuffix.countwhich I think is unexpected.Checklist