Add support for Application default credentials #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorRosocha
approved these changes
Nov 11, 2024
Contributor
IgorRosocha
left a comment
IgorRosocha
left a comment
There was a problem hiding this comment.
👋 Cocoapods, good job!
| add(to: &request) | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
❕ nitpick: redundant empty line
olejnjak
added a commit
that referenced
this pull request
Nov 17, 2024
* Prepare for App default credentials * Update GoogleAuth lib * Update CI * Make tests compilable * Fix sorted keys in tests * Remove Cocoapods support * Update changelog * Remove pods from README * Add ADC to README * Remove unused TokenProvider extension * Remove extra line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Application default credentials, this means changing from previously used and unmaintained Google authentication lib, to my implementation.
Also needed to update some CI stuff and removed Cocoapods support.