CUR-3978 implement default UI and backend permissions for all default roles of all organizations #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
waleed-backend
commented
Sep 23, 2022
waleed-backend
commented
- Assigned default UI permissions for default roles(admin, course creator, member and self-registered)
- Assigned default backend permissions for default roles(admin, course creator, member and self-registered)
- Assigned different UI and backend permissions for different environments according to the provided sheet.
added 2 commits
September 23, 2022 12:55
…role of all organization
…iveLearningStudio-API into feature/CUR-3978-implement-default-ui-permissions
| } | ||
| } | ||
|
|
||
| if (isset($this->uiModules[$permissionName]) && $this->uiModulePermissions[$permissionType][$this->uiModules[$permissionName]]) { |
Contributor
There was a problem hiding this comment.
Move "$this->uiModules[$permissionName]" to variable.
Add "isset()" for $this->uiModulePermissions[$permissionType][$this->uiModules[$permissionName]]
| } | ||
| } | ||
| // assign ui role permissions | ||
| $roleType->uiModulePermissions()->sync($uiModulePermissionIds); |
Contributor
There was a problem hiding this comment.
Use transaction in the seeder.
fahad-curriki
requested changes
Sep 23, 2022
Contributor
fahad-curriki
left a comment
fahad-curriki
left a comment
There was a problem hiding this comment.
Please do the requested changes.
fahad-curriki
approved these changes
Sep 23, 2022
Contributor
fahad-curriki
left a comment
fahad-curriki
left a comment
There was a problem hiding this comment.
PR approved, please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.