CUR-4097: Implement the Smithsonian Images API's. #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->where('name', 'Smithsonian') | ||
| ->where('media_type', 'Image') | ||
| ->first(); | ||
| if ( empty($checkAlreadyAdded) ) { |
Contributor
There was a problem hiding this comment.
Better use "updateOrInsert()" instead.
config/smithsonian.php
Outdated
| | Smithsonian API Base Url | ||
| |-------------------------------------------------------------------------- | ||
| */ | ||
| 'api_base_url' => env('Smithsonian_API_BASE_URL', 'https://api.si.edu/openaccess/api/v1.0'), |
Contributor
There was a problem hiding this comment.
Better make "Smithsonian" in uppercase as well.
Also add "Smithsonian_API_BASE_URL" and "Smithsonian_API_KEY" in ".env.example"
| } | ||
|
|
||
| /** | ||
| * Get Smithsonian Contents List |
Contributor
There was a problem hiding this comment.
Doc blocks missing for request params.
| } | ||
|
|
||
| /** | ||
| * Get Smithsonian Content Detail |
Contributor
There was a problem hiding this comment.
Doc blocks missing for request params.
fahad-curriki
approved these changes
Sep 28, 2022
Contributor
fahad-curriki
left a comment
fahad-curriki
left a comment
There was a problem hiding this comment.
PR approved, please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUR-4097: Implement the Smithsonian Images API.