Add os.environ fallback for Jython#155
Merged
Merged
Conversation
Contributor
|
Thanks Kevin. I will review later this week. Appreciate the work you put into this. |
Contributor
Author
|
Hi @zoofood, I just wanted to ping you on this and see if you need anything more from me. Thanks! |
Contributor
|
LGTM. Thanks! |
Contributor
Author
|
Thanks! Looks great. Follow up question: any sense of when the version might be iterated to 1.4.5? The pip project tries to just use release versions of embedded libraries wherever possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for issue #154
Provides an additional fallback for Windows if ctypes, JNA, and winreg all fail.
Tested and works as expected in Windows 10 with Jython 2.7.2. Also tested to verify prior behavior is unchanged against Jython 2.7.2 with JNA and CPython 3.8.5.
This also will fix the downstream pip issue, where pip is currently broken in Jython with a standard Java install.