State pull can replace project url #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrohmann
force-pushed
the
martind/pull-set-project-176209787
branch
from
ac9a195 to
2e31f76
Compare
mdrohmann
force-pushed
the
martind/pull-set-project-176209787
branch
from
2e31f76 to
f89442a
Compare
Naatan
suggested changes
Jan 8, 2021
internal/runners/pull/pull.go
Outdated
| if params.SetProject != "" { | ||
| related, err := areCommitsRelated(*target.CommitID, p.project.CommitUUID()) | ||
| if !related && !params.Force { | ||
| confirmed, err := p.prompt.Confirm(locale.T("confirm"), locale.Tl("confirm_unrelated_pull_set_project", "If you switch to {{.V0}}, you may lose changes to your project.", target.String()), false) |
Contributor
There was a problem hiding this comment.
This is missing the "Are you sure you want to do this?" Otherwise we're just prompting them for yes/no without actually giving them a prompt.
| } | ||
| } | ||
|
|
||
| err = p.project.Source().SetNamespace(target.Owner, target.Project) |
Contributor
There was a problem hiding this comment.
This seems to be redundant with line 97
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for catching. Line 97 should never have been there...
Naatan
previously approved these changes
Jan 8, 2021
This reverts commit fca00b1.
Contributor
Author
|
I had to merge with master to update the confirmation prompt, and also noticed that I accidentally added a commit from my other PR. That is reverted now. |
Naatan
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176209787