Update GetCroppedText to better handle multi-byte characters #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will work now with updates to GetCroppedText
Contributor
|
@mdrohmann I'm still not entirely clear on how runes work. Can you double check this won't have any adverse effects? |
mdrohmann
approved these changes
Jan 14, 2021
| func GetCroppedText(text string, maxLen int) CroppedLines { | ||
| entries := make([]CroppedLine, 0) | ||
| colorCodes := colorRx.FindAllStringSubmatchIndex(string(text), -1) | ||
| colorCodes := colorRx.FindAllStringSubmatchIndex(text, -1) |
Contributor
There was a problem hiding this comment.
This makes sense. It's certainly correct to use []rune as the argument type here.
len("✔ab") == 4, len([]rune("✔ab")) == 3 As we are trying to limit the "visible width", we are interested in the latter number here.
BTW: This will still not be enough, if we every support weird East-Asian locales, as these runes may be two characters wide(!). Then we'll have to use something like this
But I think that this is a problem for our future selves...
An example of runes that are two characters wide:
つつ
1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176372179