Building remotely progress fix #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrohmann
previously approved these changes
Jan 25, 2021
Naatan
suggested changes
Jan 26, 2021
Contributor
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
This still feels very fragile. I think we should ensure BuildFinished is ALWAYS called when the error channel is written.
Naatan
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176210040
@mdrohmann your suggestion was correct. Initially, I had the call to
BuildFinished()in the wrong place. After moving the call I was unable to reproduce the bug again.