Guard viper configuration with RWLock #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It is hard to tell, but I am fairly sure that if this fixed the problem. I could re-produce it once more without these changes (took a lot of tries), but now it does not seem to happen anymore... |
daved
previously approved these changes
Jan 30, 2021
internal/analytics/deferred.go
Outdated
| if err != nil { | ||
| return errs.Wrap(err, "Could not load events on send") | ||
| } | ||
| if len(deferred) == 0 { |
Contributor
There was a problem hiding this comment.
Suggestion: It might be worth, instead, using if len(deferred) > 0 and placing it around the cfg.Save below so that the "deferrerFilePath" is cleaned up.
daved
approved these changes
Feb 1, 2021
Naatan
approved these changes
Feb 1, 2021
| for n, event := range deferred { | ||
| if err := sender(event.Category, event.Action, event.Label, event.Dimensions); err != nil { | ||
| return errs.Wrap(err, "Could not send deferred event") | ||
| if len(deferred) > 0 { |
Contributor
There was a problem hiding this comment.
Nit: This is an unnecessary change.
Contributor
Author
There was a problem hiding this comment.
It skips the save of the configuration file, which I believe should be avoided if nothing changed. Of course, it doesn't affect this bug, but as we have seen that viper also has issues with concurrent writes between processes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176721598