BE-3131 Fix regression in test_signal #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickprice
force-pushed
the
BE-3131-failing-regression-test-test-signal
branch
2 times, most recently
from
59a13b9 to
74c6795
Compare
Fix for code removed by e361063. An update was also made to the if statement. Failing test: ====================================================================== FAIL: test_invalid_fd (__main__.WakeupFDTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/as-build/.cache/activestate/46e56921/usr/lib/python2.7/test/test_signal.py", line 239, in test_invalid_fd self.assertRaises(ValueError, signal.set_wakeup_fd, fd) AssertionError: ValueError not raised
rickprice
force-pushed
the
BE-3131-failing-regression-test-test-signal
branch
from
74c6795 to
bf478d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for code removed by e361063.
An update was also made to the if statement.
Failing test:
======================================================================
FAIL: test_invalid_fd (main.WakeupFDTests)
Traceback (most recent call last):
File "/home/as-build/.cache/activestate/46e56921/usr/lib/python2.7/test/test_signal.py", line 239, in test_invalid_fd
self.assertRaises(ValueError, signal.set_wakeup_fd, fd)
AssertionError: ValueError not raised