Skip to content

Conversation

@rickprice
Copy link

Fixes for CVE-2023-40217

@rickprice rickprice requested a review from icanhasmath January 30, 2024 20:58
Copy link

@icanhasmath icanhasmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this test succeed?
ca51933

Copy link

@icanhasmath icanhasmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Socket should be available in python2 : https://docs.python.org/2.7/library/socket.html

@rickprice
Copy link
Author

rickprice commented Jan 31, 2024

The problem is, Socket has to support being a resource ie "using", and I don't believe it does in Python2, from the failures I was getting.

@rickprice
Copy link
Author

Why can't this test succeed? ca51933

I need to look into it again, I believe that was the Enum problem I was having.

@rickprice rickprice force-pushed the BE-3126-cve-2023-40217 branch 2 times, most recently from 4eb7f15 to 5d88718 Compare February 6, 2024 07:23
@rickprice
Copy link
Author

rickprice commented Feb 6, 2024

Why can't this test succeed? ca51933

I'm not sure now, maybe we should put it back in?
I hate giving up tests.
There would have been a reason I removed it, but its also possible that everything is fixed now.

Ah, so the problem was that they are using an Enum to list the available versions of SSL, and Python2 just doesn't have Enums in core. If we wanted this, we would have to rewrite stuff to use something other than an Enum. I think that's possible.

@rickprice rickprice force-pushed the BE-3126-cve-2023-40217 branch from 5d88718 to d0fee9c Compare February 7, 2024 20:41
Copy link

@icanhasmath icanhasmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Tested consistently.

@icanhasmath icanhasmath merged commit 92599cd into 2.7 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants