-
Notifications
You must be signed in to change notification settings - Fork 4
CVE-2023-40217 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE-2023-40217 #34
Conversation
Without this the socket timeout code fails to compile
…IOError in Python2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't this test succeed?
ca51933
icanhasmath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Socket should be available in python2 : https://docs.python.org/2.7/library/socket.html
|
The problem is, Socket has to support being a resource ie "using", and I don't believe it does in Python2, from the failures I was getting. |
I need to look into it again, I believe that was the Enum problem I was having. |
4eb7f15 to
5d88718
Compare
I'm not sure now, maybe we should put it back in? Ah, so the problem was that they are using an Enum to list the available versions of SSL, and Python2 just doesn't have Enums in core. If we wanted this, we would have to rewrite stuff to use something other than an Enum. I think that's possible. |
5d88718 to
d0fee9c
Compare
icanhasmath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Tested consistently.
Fixes for CVE-2023-40217